[MRG] document gather abund tests a bit better; minor refactoring #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 92.22% 92.22%
=======================================
Files 72 72
Lines 5211 5211
=======================================
Hits 4806 4806
Misses 405 405 Continue to review full report at Codecov.
|
|
I think the main thing still needed here is to update the docs with some actual numbers re gather-abund output and meaning. |
ctb
changed the title
|
hi @taylorreiter @luizirber ready for review. |
luizirber
approved these changes
Apr 28, 2020
This was referenced May 3, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #885, update tests with some slightly better documentation about what abundance projection is doing.
Fixes #461
ref @dkoslicki who was interested in how sourmash did these things.
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?